Nodejs version Upgrade to 20#2650
Open
jainakanksha-msft wants to merge 9 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR raises Azurite’s declared Node.js runtime floor to Node 20 and updates PR validation coverage to newer Node.js versions.
Changes:
- Updates
package.jsonengines.nodefrom>=10.0.0to>=20.0.0. - Reworks GitHub Actions PR validation jobs to run primarily against Node 20, 22, and 24.
- Updates workflow formatting and command indentation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
package.json |
Raises the package’s minimum supported Node.js version. |
.github/workflows/PrValidation.yml |
Updates CI job names and Node versions used for validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
18
to
21
| "engines": { | ||
| "node": ">=10.0.0", | ||
| "node": ">=21.0.0", | ||
| "vscode": "^1.39.0" | ||
| }, |
Comment on lines
+995
to
+1001
| Azurite binary builds now use Node.js SEA (Single Executable Applications) with `esbuild` and `postject`. | ||
|
|
||
| Prerequisites: | ||
|
|
||
| - Node.js 24.x (required for local SEA binary build scripts) | ||
| - Installed dependencies (`npm ci`) | ||
| - Built TypeScript output (`npm run build`) so `dist/src/azurite.js` exists |
Comment on lines
52
to
+56
| matrix: | ||
| node_16_x: | ||
| node_version: 16.x | ||
| node_18_x: | ||
| node_version: 18.x | ||
| node_24_x: | ||
| node_version: 24.x |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+77
to
+81
| async function runAudit() { | ||
| await runEsbuildAudit(distEntry, `node${process.versions.node.split('.')[0]}`); | ||
| auditDynamicImports(path.resolve('./dist/src')); | ||
| } | ||
| } |
| bundle: true, | ||
| target: [`node${process.versions.node.split('.')[0]}`], | ||
| external: optionalExternalModules, | ||
| outfile: outputPath, |
Comment on lines
18
to
20
| "engines": { | ||
| "node": ">=10.0.0", | ||
| "node": ">=21.0.0", | ||
| "vscode": "^1.39.0" |
Comment on lines
53
to
+56
| node_16_x: | ||
| node_version: 16.x | ||
| node_18_x: | ||
| node_version: 18.x | ||
| node_24_x: | ||
| node_version: 24.x |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+95
to
+103
| await esbuild.build({ | ||
| entryPoints: [distEntry], | ||
| bundle: true, | ||
| target: [`node${process.versions.node.split('.')[0]}`], | ||
| external: optionalExternalModules, | ||
| outfile: outputPath, | ||
| sourcemap: false, | ||
| minify: false | ||
| }); |
Comment on lines
18
to
21
| "engines": { | ||
| "node": ">=10.0.0", | ||
| "node": ">=21.0.0", | ||
| "vscode": "^1.39.0" | ||
| }, |
Comment on lines
+999
to
+1001
| - Node.js 24.x (required for local SEA binary build scripts) | ||
| - Installed dependencies (`npm ci`) | ||
| - Built TypeScript output (`npm run build`) so `dist/src/azurite.js` exists |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.